feat: Send transactions in envelopes #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhcarvalho
commented
Jun 22, 2020
rhcarvalho
force-pushed
the
rhcarvalho/send-transactions-as-envelopes
branch
from
3910fa9 to
7c68b5e
Compare
This matches what the JS SDK does and what the Tracing dev docs indicates.
rhcarvalho
force-pushed
the
rhcarvalho/send-transactions-as-envelopes
branch
from
7c68b5e to
2e613a2
Compare
untitaker
reviewed
Jun 26, 2020
| pass | ||
|
|
||
| if sample_rate: | ||
| (event,) = events |
Member
There was a problem hiding this comment.
I really like this pattern! :P
Contributor
Author
There was a problem hiding this comment.
I don't dislike it. The problem was the kind of output we were getting when the test fails "not enough values to unpack" or "too many values to unpack", no clue what the events were.
The fix is adding an assert so that pytest handles printing the contents of events. Could have kept the unpacking, but now I don't want to trigger CI again.
Member
There was a problem hiding this comment.
that's also been a complaint from @mitsuhiko. I might make a pytest plugin that does something similar to assertion rewrites
untitaker
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches what the JS SDK does and what the Tracing dev docs indicates.
Related: #730