fix(metrics): Change data_category from statsd to metric_bucket (#2954)

The event category for emitted metrics is metric_bucket and not statsd.

---------

Co-authored-by: Anton Pirker <[email protected]>

Author: cleptric

sentry_sdk/_types.py

@@ -113,7 +113,7 @@
         "session",
         "internal",
         "profile",
-        "statsd",
+        "metric_bucket",
         "monitor",
     ]
     SessionStatus = Literal["ok", "exited", "crashed", "abnormal"]

sentry_sdk/envelope.py

@@ -261,7 +261,7 @@ def data_category(self):
         elif ty == "profile":
             return "profile"
         elif ty == "statsd":
-            return "statsd"
+            return "metric_bucket"
         elif ty == "check_in":
             return "monitor"
         else:

sentry_sdk/transport.py

@@ -222,11 +222,6 @@ def record_lost_event(
                 # quantity of 0 is actually 1 as we do not want to count
                 # empty attachments as actually empty.
                 quantity = len(item.get_bytes()) or 1
-            if data_category == "statsd":
-                # The envelope item type used for metrics is statsd
-                # whereas the client report category for discarded events
-                # is metric_bucket
-                data_category = "metric_bucket"
 
         elif data_category is None:
             raise TypeError("data category not provided")