Skip to content

Commit e6b22bb

Browse files
cleptricstayallive
andauthored
ref: Align Span Operations with new spec (#574)
Co-authored-by: Alex Bouma <[email protected]>
1 parent 2224e80 commit e6b22bb

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
- Fix not listening to queue events because `QueueManager` is registered as `queue` in the container and not by it's class name (#568)
66
- Fix status code not populated on transaction if response did not inherit from `Illuminate\Http\Response` like `Illuminate\Http\JsonResponse` (#573)
7+
- Align Span Operations with new spec (#574)
78
- Fix broken `SetRequestMiddleware` on Laravel < 6.0 (#575)
89

910
## 2.13.0

src/Sentry/Laravel/Tracing/Middleware.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ private function startTransaction(Request $request, HubInterface $sentry): void
123123
$bootstrapSpan = $this->addAppBootstrapSpan($request);
124124

125125
$appContextStart = new SpanContext();
126-
$appContextStart->setOp('laravel.handle');
126+
$appContextStart->setOp('middleware.handle');
127127
$appContextStart->setStartTimestamp($bootstrapSpan ? $bootstrapSpan->getEndTimestamp() : microtime(true));
128128

129129
$this->appSpan = $this->transaction->startChild($appContextStart);
@@ -144,7 +144,7 @@ private function addAppBootstrapSpan(Request $request): ?Span
144144
}
145145

146146
$spanContextStart = new SpanContext();
147-
$spanContextStart->setOp('laravel.bootstrap');
147+
$spanContextStart->setOp('app.bootstrap');
148148
$spanContextStart->setStartTimestamp($laravelStartTime);
149149
$spanContextStart->setEndTimestamp($this->bootedTimestamp);
150150

@@ -168,7 +168,7 @@ private function addBootDetailTimeSpans(Span $bootstrap): void
168168
}
169169

170170
$autoload = new SpanContext();
171-
$autoload->setOp('laravel.autoload');
171+
$autoload->setOp('app.php.autoload');
172172
$autoload->setStartTimestamp($bootstrap->getStartTimestamp());
173173
$autoload->setEndTimestamp(SENTRY_AUTOLOAD);
174174

src/Sentry/Laravel/Tracing/ViewEngineDecorator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function get($path, array $data = []): string
3636
}
3737

3838
$context = new SpanContext();
39-
$context->setOp('laravel.view');
39+
$context->setOp('view.render');
4040
$context->setDescription($this->viewFactory->shared(self::SHARED_KEY, basename($path)));
4141

4242
$span = $parentSpan->startChild($context);

0 commit comments

Comments
 (0)