Skip to content

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented May 8, 2023

  • Detekt for enforcing some doc rules and general code smells
  • Dokka deploy to gh-pages
  • Since we will be enforcing docs on public components, Dokka will be generally in a good state

I've also updated the docs and naming of Scope to make it clear what it does.

#skip-changelog

@buenaflor buenaflor requested a review from marandaneto May 8, 2023 17:01
@buenaflor buenaflor requested a review from marandaneto May 16, 2023 15:29
@buenaflor buenaflor merged commit a1d4010 into main May 17, 2023
@buenaflor buenaflor deleted the chore/detekt-dokka branch May 17, 2023 09:33
buenaflor added a commit to buenaflor/sentry-kotlin-multiplatform-1 that referenced this pull request Jul 4, 2023
* add detekt

* apply detekt changes

* add dokka

* add dokka action

* update dokka action

* depend generate-dokka on build

* update scope naming:

* update scope doc

* update ScopeDecorator docs

* add detekt make target

* Format code

* add detekt to .PHONY

* update Scope

* update API

* fix format

* update tests

* add changelog

* add separate workflow for generate dokka

* Remove Suppress annotations

* ignore forbidden comments and revert changelog

* exclude Attachment from unused private member

* Add baseline task

* Update generate-dokka.yml

* Update detekt.yml

---------

Co-authored-by: Sentry Github Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants