From 8aeddaf7741eac7bc0451d12ae605677c706201f Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Tue, 22 Jul 2025 13:05:52 +0200 Subject: [PATCH 1/5] Update --- .../io/sentry/kotlin/multiplatform/gradle/SentryPlugin.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/SentryPlugin.kt b/sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/SentryPlugin.kt index 6635bf29..0aaa1367 100644 --- a/sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/SentryPlugin.kt +++ b/sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/SentryPlugin.kt @@ -149,14 +149,14 @@ internal fun Project.installSentryForKmp( return } - val unsupportedTargets = listOf("wasm", "js", "mingw", "linux", "androidNative") + val unsupportedTargets = listOf("androidNative") kmpExtension.targets.forEach { target -> if (unsupportedTargets.any { unsupported -> target.name.contains(unsupported) }) { throw GradleException( "Unsupported target: ${target.name}. " + "Cannot auto install in commonMain. " + "Please create an intermediate sourceSet with targets that the Sentry SDK " + - "supports (apple, jvm, android) and add the dependency manually." + "supports and add the dependency manually." ) } } From fdc29f6cf77dc11bf4ce782265fb707e892238bd Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Tue, 22 Jul 2025 13:07:11 +0200 Subject: [PATCH 2/5] Update --- .../sentry/kotlin/multiplatform/gradle/SentryPluginTest.kt | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/SentryPluginTest.kt b/sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/SentryPluginTest.kt index b1f2f830..99c8dba5 100644 --- a/sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/SentryPluginTest.kt +++ b/sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/SentryPluginTest.kt @@ -154,9 +154,8 @@ class SentryPluginTest { assertTrue(commonMainConfiguration!!.dependencies.contains(sentryDependency)) } - @OptIn(ExperimentalWasmDsl::class) @ParameterizedTest(name = "installSentryForKmp throws if build contains unsupported target {0}") - @ValueSource(strings = ["wasm", "js", "mingw", "linux", "androidNative"]) + @ValueSource(strings = ["androidNative"]) fun `installSentryForKmp throws if build contains any unsupported target`(unsupportedTarget: String) { val project = ProjectBuilder.builder().build() project.pluginManager.apply("org.jetbrains.kotlin.multiplatform") @@ -165,10 +164,6 @@ class SentryPluginTest { val kmpExtension = project.extensions.getByType(KotlinMultiplatformExtension::class.java) kmpExtension.apply { when (unsupportedTarget) { - "wasm" -> wasmJs() - "js" -> js() - "mingw" -> mingwX64() - "linux" -> linuxX64() "androidNative" -> androidNativeArm64() } } From 6b746ff3c8b5cd4e521da03715a8523e3dafc545 Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Tue, 22 Jul 2025 13:13:00 +0200 Subject: [PATCH 3/5] Update --- .../io/sentry/kotlin/multiplatform/gradle/SentryPluginTest.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/SentryPluginTest.kt b/sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/SentryPluginTest.kt index 99c8dba5..5af06837 100644 --- a/sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/SentryPluginTest.kt +++ b/sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/SentryPluginTest.kt @@ -6,7 +6,6 @@ import org.gradle.api.plugins.ExtensionAware import org.gradle.testfixtures.ProjectBuilder import org.jetbrains.kotlin.gradle.dsl.KotlinMultiplatformExtension import org.jetbrains.kotlin.gradle.plugin.cocoapods.CocoapodsExtension -import org.jetbrains.kotlin.gradle.targets.js.dsl.ExperimentalWasmDsl import org.junit.jupiter.api.Assertions.assertEquals import org.junit.jupiter.api.Assertions.assertNotNull import org.junit.jupiter.api.Assertions.assertNull From 0b167385b83d10fe0423079bb9174f6a68d21a34 Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Tue, 22 Jul 2025 13:13:37 +0200 Subject: [PATCH 4/5] Update --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f841d24d..7e7fde33 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,12 @@ ## Unreleased +### Fixes + +- Gradle Plugin: allow new supported targets to be installed ([#429](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/429)) + +## 0.17.0 + ### Features - Add stubs/no-op support for unsupported targets ([#426](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/426)) From 41632ba241a1f51ab437e785d254cd6f5807aad7 Mon Sep 17 00:00:00 2001 From: Giancarlo Buenaflor Date: Tue, 22 Jul 2025 13:30:53 +0200 Subject: [PATCH 5/5] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 548f3838..7e7fde33 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ # Changelog -## 0.17.0 +## Unreleased ### Fixes