From b3d6091cb881eaccd5a1de3be1dcd91949749cd3 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 4 Dec 2023 19:05:59 +0100 Subject: [PATCH 1/3] fix(feedback): Add package resolution for Remix and NextJS Integration tests --- packages/nextjs/test/integration/package.json | 1 + packages/remix/test/integration/package.json | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/nextjs/test/integration/package.json b/packages/nextjs/test/integration/package.json index b62f4583e188..0bbe126a10b6 100644 --- a/packages/nextjs/test/integration/package.json +++ b/packages/nextjs/test/integration/package.json @@ -33,6 +33,7 @@ "@sentry/replay": "file:../../../replay", "@sentry/tracing": "file:../../../tracing", "@sentry-internal/tracing": "file:../../../tracing-internal", + "@sentry-internal/feedback": "file:../../../feedback", "@sentry/types": "file:../../../types", "@sentry/utils": "file:../../../utils", "@sentry/vercel-edge": "file:../../../vercel-edge" diff --git a/packages/remix/test/integration/package.json b/packages/remix/test/integration/package.json index f72262e64167..a4ad4f4e3423 100644 --- a/packages/remix/test/integration/package.json +++ b/packages/remix/test/integration/package.json @@ -31,6 +31,7 @@ "@sentry/replay": "file:../../../replay", "@sentry/tracing": "file:../../../tracing", "@sentry-internal/tracing": "file:../../../tracing-internal", + "@sentry-internal/feedback": "file:../../../feedback", "@sentry/types": "file:../../../types", "@sentry/utils": "file:../../../utils", "@vanilla-extract/css": "1.13.0" From 4070784d96f5fd8ae0f1c70d42162fe827d6e89a Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 4 Dec 2023 19:08:44 +0100 Subject: [PATCH 2/3] add entry in checklist --- docs/new-sdk-release-checklist.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/new-sdk-release-checklist.md b/docs/new-sdk-release-checklist.md index c02f0d01c1ef..5319e9c86dd2 100644 --- a/docs/new-sdk-release-checklist.md +++ b/docs/new-sdk-release-checklist.md @@ -49,6 +49,8 @@ This page serves as a checklist of what to do when releasing a new SDK for the f - [ ] Make sure it is added to the [Verdaccio config](https://github.com/getsentry/sentry-javascript/blob/develop/packages/e2e-tests/verdaccio-config/config.yaml) for the E2E tests +- [ ] If the package you're adding is a dependency of fullstack frameworks (e.g. Remix or NextJS), make sure that your package is added to the integration test apps' `"resolutions"` field in their `package.json`s. + ## Cutting the Release When you’re ready to make the first release, there are a couple of steps that need to be performed in the **correct order**. Note that you can prepare the PRs at any time but the **merging oder** is important: From df4d81e48e49136e9d2b6bb4ea86134674ec3cf3 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 4 Dec 2023 19:16:26 +0100 Subject: [PATCH 3/3] Update docs/new-sdk-release-checklist.md --- docs/new-sdk-release-checklist.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/new-sdk-release-checklist.md b/docs/new-sdk-release-checklist.md index 5319e9c86dd2..fc7cd8be3edf 100644 --- a/docs/new-sdk-release-checklist.md +++ b/docs/new-sdk-release-checklist.md @@ -49,7 +49,7 @@ This page serves as a checklist of what to do when releasing a new SDK for the f - [ ] Make sure it is added to the [Verdaccio config](https://github.com/getsentry/sentry-javascript/blob/develop/packages/e2e-tests/verdaccio-config/config.yaml) for the E2E tests -- [ ] If the package you're adding is a dependency of fullstack frameworks (e.g. Remix or NextJS), make sure that your package is added to the integration test apps' `"resolutions"` field in their `package.json`s. +- [ ] If the package you're adding is a dependency of fullstack framework (e.g. Remix or NextJS) SDKs, make sure that your package is added to the integration test apps' `"resolutions"` field in their `package.json`s. ## Cutting the Release