From f74c5bc074388bd75abf50239a24603851ca24c6 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Fri, 27 Oct 2023 07:01:43 +0000 Subject: [PATCH 1/4] test(e2e): Run e2e tests for Next.js 13 and 14 --- .github/workflows/canary.yml | 3 +++ .../e2e-tests/test-applications/nextjs-app-dir/package.json | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/canary.yml b/.github/workflows/canary.yml index 04adce087fd4..e11abb024834 100644 --- a/.github/workflows/canary.yml +++ b/.github/workflows/canary.yml @@ -73,6 +73,9 @@ jobs: - test-application: 'nextjs-app-dir' build-command: 'test:build-latest' label: 'nextjs-app-dir (latest)' + - test-application: 'nextjs-app-dir' + build-command: 'test:build-13' + label: 'nextjs-app-dir (v13)' - test-application: 'react-create-hash-router' build-command: 'test:build-canary' label: 'react-create-hash-router (canary)' diff --git a/packages/e2e-tests/test-applications/nextjs-app-dir/package.json b/packages/e2e-tests/test-applications/nextjs-app-dir/package.json index 461eabaf4dc2..ec3b43e528e0 100644 --- a/packages/e2e-tests/test-applications/nextjs-app-dir/package.json +++ b/packages/e2e-tests/test-applications/nextjs-app-dir/package.json @@ -11,6 +11,7 @@ "test:test-build": "pnpm ts-node --script-mode assert-build.ts", "test:build-canary": "pnpm install && pnpm add next@canary && npx playwright install && pnpm build", "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build", + "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build", "test:assert": "pnpm test:test-build && pnpm test:prod && pnpm test:dev" }, "dependencies": { @@ -19,7 +20,7 @@ "@types/node": "18.11.17", "@types/react": "18.0.26", "@types/react-dom": "18.0.9", - "next": "13.4.19", + "next": "14.0.0", "react": "18.2.0", "react-dom": "18.2.0", "typescript": "4.9.5", From d3108d743af68a59faed2bf9acc681f6b1cf8179 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Fri, 27 Oct 2023 07:25:08 +0000 Subject: [PATCH 2/4] not canary but PRs --- .github/workflows/build.yml | 3 +++ .github/workflows/canary.yml | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 806bfd4edc2f..5e7077c50c98 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -884,6 +884,9 @@ jobs: - test-application: 'standard-frontend-react' build-command: 'test:build-ts3.8' label: 'standard-frontend-react (TS 3.8)' + - test-application: 'standard-frontend-react' + build-command: 'test:build-13' + label: 'nextjs-app-dir (next@13)' steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) diff --git a/.github/workflows/canary.yml b/.github/workflows/canary.yml index e11abb024834..04adce087fd4 100644 --- a/.github/workflows/canary.yml +++ b/.github/workflows/canary.yml @@ -73,9 +73,6 @@ jobs: - test-application: 'nextjs-app-dir' build-command: 'test:build-latest' label: 'nextjs-app-dir (latest)' - - test-application: 'nextjs-app-dir' - build-command: 'test:build-13' - label: 'nextjs-app-dir (v13)' - test-application: 'react-create-hash-router' build-command: 'test:build-canary' label: 'react-create-hash-router (canary)' From cd9d876727f156ca770d2444c43c1fab7e743681 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Fri, 27 Oct 2023 07:29:48 +0000 Subject: [PATCH 3/4] . --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5e7077c50c98..b76069837089 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -884,7 +884,7 @@ jobs: - test-application: 'standard-frontend-react' build-command: 'test:build-ts3.8' label: 'standard-frontend-react (TS 3.8)' - - test-application: 'standard-frontend-react' + - test-application: 'nextjs-app-dir' build-command: 'test:build-13' label: 'nextjs-app-dir (next@13)' From 72c0a262382534c889777b1294725d5714e72390 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Fri, 27 Oct 2023 10:42:58 +0000 Subject: [PATCH 4/4] . --- .github/workflows/build.yml | 3 +++ .../e2e-tests/test-applications/create-next-app/package.json | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b76069837089..4b3125c09eb1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -884,6 +884,9 @@ jobs: - test-application: 'standard-frontend-react' build-command: 'test:build-ts3.8' label: 'standard-frontend-react (TS 3.8)' + - test-application: 'create-next-app' + build-command: 'test:build-13' + label: 'create-next-app (next@13)' - test-application: 'nextjs-app-dir' build-command: 'test:build-13' label: 'nextjs-app-dir (next@13)' diff --git a/packages/e2e-tests/test-applications/create-next-app/package.json b/packages/e2e-tests/test-applications/create-next-app/package.json index 58b89cb7dda7..c74dc5c414e1 100644 --- a/packages/e2e-tests/test-applications/create-next-app/package.json +++ b/packages/e2e-tests/test-applications/create-next-app/package.json @@ -8,6 +8,7 @@ "test:prod": "TEST_ENV=prod playwright test", "test:dev": "TEST_ENV=dev playwright test", "test:build": "pnpm install && npx playwright install && pnpm build", + "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build", "test:assert": "pnpm test:prod && pnpm test:dev" }, "dependencies": { @@ -16,7 +17,7 @@ "@types/node": "18.11.17", "@types/react": "18.0.26", "@types/react-dom": "18.0.9", - "next": "13.0.7", + "next": "14.0.0", "react": "18.2.0", "react-dom": "18.2.0", "typescript": "4.9.5"