Skip to content

fix(remix): Update defer injection logic. #9242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix(remix): Update defer injection logic. #9242

merged 1 commit into from
Oct 16, 2023

Conversation

@onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Oct 13, 2023 •
edited
Loading

Fixes: #9235

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 84.27 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.43 KB (0%)
@sentry/browser - Webpack (gzipped) 22.02 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 78.79 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.61 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.02 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 254.51 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.76 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 62.45 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.48 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 84.3 KB (0%)
@sentry/react - Webpack (gzipped) 22.06 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 102.21 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 50.96 KB (0%)

@onurtemizkan onurtemizkan force-pushed the onur/fix-remix-defer-instrumentation branch 2 times, most recently from 2cafe14 to f62cfd4 Compare October 13, 2023 15:43
@onurtemizkan onurtemizkan force-pushed the onur/fix-remix-defer-instrumentation branch from f62cfd4 to ce74034 Compare October 13, 2023 16:05
@onurtemizkan onurtemizkan marked this pull request as ready for review October 13, 2023 16:05
@AbhiPrasad AbhiPrasad merged commit e4a1440 into develop Oct 16, 2023
@AbhiPrasad AbhiPrasad deleted the onur/fix-remix-defer-instrumentation branch October 16, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@sentry/remix createSentryRequestHandler makes deferred data in root loader resolve {} instead of original data.

3 participants

@onurtemizkan @AbhiPrasad