meta: Don't gitignore .d.ts files
#8472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
mydea
approved these changes
Jul 7, 2023
Member
mydea
left a comment
mydea
left a comment
There was a problem hiding this comment.
yeah, I noticed this as well some time in the past, makes sense to me!
AbhiPrasad
approved these changes
Jul 7, 2023
Lms24
approved these changes
Jul 10, 2023
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Considering we're gitignoring ./build anyway, I think this is fine!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking at getsentry/sentry-capacitor#249 and getsentry/sentry-capacitor#394 and trying to fix this by adding a bunch of
.d.tsfiles but they were gitignored.I don't think we should blanket-ignore dts files so this pr removes it from gitignore.