From 7563d56f51b9a14a28fc084733df4f2e47482fc1 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Wed, 14 Jun 2023 11:36:00 +0200 Subject: [PATCH 1/2] fix(replay): Do not export types from `@sentry-internal/rrweb` (#8329) This breaks, as we do not have these packages as dependencies but devDependencies, but the types are not inlined... This was introduced here: https://github.com/getsentry/sentry-javascript/pull/8284 Fixes https://github.com/getsentry/sentry-javascript/issues/8326 --- packages/replay/src/index.ts | 5 +---- .../replay/test/integration/beforeAddRecordingEvent.test.ts | 3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/replay/src/index.ts b/packages/replay/src/index.ts index 3e6b01f39f5c..7664b4d4e592 100644 --- a/packages/replay/src/index.ts +++ b/packages/replay/src/index.ts @@ -1,5 +1,6 @@ export { Replay } from './integration'; export type { + eventWithTime, BreadcrumbFrame, BreadcrumbFrameEvent, OptionFrameEvent, @@ -8,7 +9,3 @@ export type { SpanFrame, SpanFrameEvent, } from './types'; -export { EventType } from '@sentry-internal/rrweb'; -export { NodeType } from '@sentry-internal/rrweb-snapshot'; -export type { eventWithTime, fullSnapshotEvent } from '@sentry-internal/rrweb'; -export type { serializedNodeWithId } from '@sentry-internal/rrweb-snapshot'; diff --git a/packages/replay/test/integration/beforeAddRecordingEvent.test.ts b/packages/replay/test/integration/beforeAddRecordingEvent.test.ts index ba1a63d904fd..9f89aba9b517 100644 --- a/packages/replay/test/integration/beforeAddRecordingEvent.test.ts +++ b/packages/replay/test/integration/beforeAddRecordingEvent.test.ts @@ -1,8 +1,9 @@ +import type { EventType } from '@sentry-internal/rrweb'; import * as SentryCore from '@sentry/core'; import type { Transport } from '@sentry/types'; import * as SentryUtils from '@sentry/utils'; -import type { EventType, Replay } from '../../src'; +import type { Replay } from '../../src'; import type { ReplayContainer } from '../../src/replay'; import { clearSession } from '../../src/session/clearSession'; import * as SendReplayRequest from '../../src/util/sendReplayRequest'; From 010315d54e388b1d608871491df5d0d2393b8746 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Wed, 14 Jun 2023 11:53:40 +0200 Subject: [PATCH 2/2] meta(changelog): Update changelog for 7.55.1 --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8c123a1545b5..53e54fd33bba 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott +## 7.55.1 + +- fix(replay): Do not export types from `@sentry-internal/rrweb` (#8329) + ## 7.55.0 - feat(replay): Capture slow clicks (GA) (#8298)