From fd8dbfe8282f4a19304090ea8068df8b005177ee Mon Sep 17 00:00:00 2001
From: Luca Forstner <luca.forstner@sentry.io>
Date: Wed, 19 Apr 2023 10:34:56 +0000
Subject: [PATCH 1/2] ref(nextjs): Don't use Sentry Webpack Plugin in dev mode

---
 packages/nextjs/src/config/webpack.ts | 31 ++++++++-------------------
 1 file changed, 9 insertions(+), 22 deletions(-)

diff --git a/packages/nextjs/src/config/webpack.ts b/packages/nextjs/src/config/webpack.ts
index 13ec394abb34..e00ac0d6a659 100644
--- a/packages/nextjs/src/config/webpack.ts
+++ b/packages/nextjs/src/config/webpack.ts
@@ -285,14 +285,14 @@ export function constructWebpackConfigFunction(
         // front-end-only problem, and because `sentry-cli` handles sourcemaps more reliably with the comment than
         // without, the option to use `hidden-source-map` only applies to the client-side build.
         newConfig.devtool = userSentryOptions.hideSourceMaps && !isServer ? 'hidden-source-map' : 'source-map';
-      }
 
-      newConfig.plugins = newConfig.plugins || [];
-      newConfig.plugins.push(
-        new SentryWebpackPlugin(
-          getWebpackPluginOptions(buildContext, userSentryWebpackPluginOptions, userSentryOptions),
-        ),
-      );
+        newConfig.plugins = newConfig.plugins || [];
+        newConfig.plugins.push(
+          new SentryWebpackPlugin(
+            getWebpackPluginOptions(buildContext, userSentryWebpackPluginOptions, userSentryOptions),
+          ),
+        );
+      }
     }
 
     return newConfig;
@@ -584,7 +584,7 @@ export function getWebpackPluginOptions(
   userPluginOptions: Partial<SentryWebpackPluginOptions>,
   userSentryOptions: UserSentryOptions,
 ): SentryWebpackPluginOptions {
-  const { buildId, isServer, webpack, config, dev: isDev, dir: projectDir } = buildContext;
+  const { buildId, isServer, webpack, config, dir: projectDir } = buildContext;
   const userNextConfig = config as NextConfigObject;
 
   const distDirAbsPath = path.resolve(projectDir, userNextConfig.distDir || '.next'); // `.next` is the default directory
@@ -628,7 +628,6 @@ export function getWebpackPluginOptions(
     urlPrefix,
     entries: [], // The webpack plugin's release injection breaks the `app` directory - we inject the release manually with the value injection loader instead.
     release: getSentryRelease(buildId),
-    dryRun: isDev,
   });
 
   checkWebpackPluginOverrides(defaultPluginOptions, userPluginOptions);
@@ -733,7 +732,7 @@ export function getWebpackPluginOptions(
 
 /** Check various conditions to decide if we should run the plugin */
 function shouldEnableWebpackPlugin(buildContext: BuildContext, userSentryOptions: UserSentryOptions): boolean {
-  const { isServer, dev: isDev } = buildContext;
+  const { isServer } = buildContext;
   const { disableServerWebpackPlugin, disableClientWebpackPlugin } = userSentryOptions;
 
   /** Non-negotiable */
@@ -758,18 +757,6 @@ function shouldEnableWebpackPlugin(buildContext: BuildContext, userSentryOptions
     return !disableClientWebpackPlugin;
   }
 
-  /** Situations where the default is to disable the plugin */
-
-  // TODO: Are there analogs to Vercel's preveiw and dev modes on other deployment platforms?
-
-  if (isDev || process.env.NODE_ENV === 'development') {
-    // TODO (v8): Right now in dev we set the plugin to dryrun mode, and our boilerplate includes setting the plugin to
-    // `silent`, so for the vast majority of users, it's as if the plugin doesn't run at all in dev. Making that
-    // official is technically a breaking change, though, so we probably should wait until v8.
-    // return false
-  }
-
-  // We've passed all of the tests!
   return true;
 }
 

From 235eb9054f5c3c4426efa723221dde3c9f7a1710 Mon Sep 17 00:00:00 2001
From: Luca Forstner <luca.forstner@sentry.io>
Date: Wed, 19 Apr 2023 11:43:39 +0000
Subject: [PATCH 2/2] adjust test

---
 packages/nextjs/test/config/webpack/sentryWebpackPlugin.test.ts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/packages/nextjs/test/config/webpack/sentryWebpackPlugin.test.ts b/packages/nextjs/test/config/webpack/sentryWebpackPlugin.test.ts
index bc6b8dd458a1..1ec6af7212a1 100644
--- a/packages/nextjs/test/config/webpack/sentryWebpackPlugin.test.ts
+++ b/packages/nextjs/test/config/webpack/sentryWebpackPlugin.test.ts
@@ -39,7 +39,6 @@ describe('Sentry webpack plugin config', () => {
         urlPrefix: '~/_next', // default
         entries: [],
         release: 'doGsaREgReaT', // picked up from env
-        dryRun: false, // based on buildContext.dev being false
       }),
     );
   });