fix(sveltekit): Rewrite server-side stack frames to match uploaded artifacts #7831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
AbhiPrasad
approved these changes
Apr 13, 2023
| "dependencies": { | ||
| "@sentry-internal/tracing": "7.47.0", | ||
| "@sentry/core": "7.47.0", | ||
| "@sentry/integrations": "7.47.0", |
Member
There was a problem hiding this comment.
Unrelated note: should we just export RewriteFrames from @sentry/core considering how much we use it everywhere?
Member
Author
There was a problem hiding this comment.
I guess we could! Core would need to depend on integrations but this should be fine
Member
There was a problem hiding this comment.
I'm thinking opposite - integrations depends on core!
Member
Author
There was a problem hiding this comment.
Sure that also works 😅 I can do this but let's do it in another PR after this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
RewriteFramesintegration to match the server-side stack frames with the uploaded source maps.(since I'm still facing super weird timing issues with the debug Ids I'll try to get source maps working in the conventional way and revisit later)
ref #7669