From 93add4f52370f7a9bc73ae2677cc19b8a5ff8d79 Mon Sep 17 00:00:00 2001 From: JonasBa Date: Mon, 13 Mar 2023 14:34:12 -0400 Subject: [PATCH 1/3] fix(profiling): catch sendProfile rejection --- packages/browser/src/profiling/sendProfile.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/browser/src/profiling/sendProfile.ts b/packages/browser/src/profiling/sendProfile.ts index 6637e86c8f44..d73d002d90ee 100644 --- a/packages/browser/src/profiling/sendProfile.ts +++ b/packages/browser/src/profiling/sendProfile.ts @@ -82,5 +82,12 @@ export function sendProfile(profileId: string, profile: ProcessedJSSelfProfile): logger.log('[Profiling] Envelope constructed, sending it'); } - void transport.send(envelope); + // Wrap in try/catch because send will throw in case of a network error. + transport.send(envelope).then(null, error => { + if (error) { + if (__DEBUG_BUILD__) { + logger.log('[Profiling] Envelope constructed, sending it'); + } + } + }); } From 2f0a988224dd4b0e9a235b422240f5681befdb9e Mon Sep 17 00:00:00 2001 From: Jonas Date: Mon, 13 Mar 2023 16:09:46 -0400 Subject: [PATCH 2/3] Update packages/browser/src/profiling/sendProfile.ts Co-authored-by: Abhijeet Prasad --- packages/browser/src/profiling/sendProfile.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/browser/src/profiling/sendProfile.ts b/packages/browser/src/profiling/sendProfile.ts index d73d002d90ee..bd0ec71b15e6 100644 --- a/packages/browser/src/profiling/sendProfile.ts +++ b/packages/browser/src/profiling/sendProfile.ts @@ -83,11 +83,7 @@ export function sendProfile(profileId: string, profile: ProcessedJSSelfProfile): } // Wrap in try/catch because send will throw in case of a network error. - transport.send(envelope).then(null, error => { - if (error) { - if (__DEBUG_BUILD__) { - logger.log('[Profiling] Envelope constructed, sending it'); - } - } + transport.send(envelope).then(null, reason => { + __DEBUG_BUILD__ && logger.log('[Profiling] Error while sending event:', reason'); }); } From f25699612948760f7a9c6bfa7f2c85b7dd7fc6e6 Mon Sep 17 00:00:00 2001 From: JonasBa Date: Mon, 13 Mar 2023 16:33:23 -0400 Subject: [PATCH 3/3] fix: typo on string literal --- packages/browser/src/profiling/sendProfile.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/browser/src/profiling/sendProfile.ts b/packages/browser/src/profiling/sendProfile.ts index bd0ec71b15e6..83ca990c516e 100644 --- a/packages/browser/src/profiling/sendProfile.ts +++ b/packages/browser/src/profiling/sendProfile.ts @@ -84,6 +84,6 @@ export function sendProfile(profileId: string, profile: ProcessedJSSelfProfile): // Wrap in try/catch because send will throw in case of a network error. transport.send(envelope).then(null, reason => { - __DEBUG_BUILD__ && logger.log('[Profiling] Error while sending event:', reason'); + __DEBUG_BUILD__ && logger.log('[Profiling] Error while sending event:', reason); }); }