From 59390d4e3ea0ea589589f7dc609a04eddc6f5d57 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Mon, 13 Mar 2023 12:52:06 +0000 Subject: [PATCH 1/2] feat(nextjs): Run source map upload in Vercel develop and preview environments --- packages/nextjs/src/config/webpack.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/nextjs/src/config/webpack.ts b/packages/nextjs/src/config/webpack.ts index a606af5f339c..e4d4400f1c5d 100644 --- a/packages/nextjs/src/config/webpack.ts +++ b/packages/nextjs/src/config/webpack.ts @@ -701,10 +701,6 @@ function shouldEnableWebpackPlugin(buildContext: BuildContext, userSentryOptions // return false } - if (process.env.VERCEL_ENV === 'preview' || process.env.VERCEL_ENV === 'development') { - return false; - } - // We've passed all of the tests! return true; } From 93a2ccc62e8fb2dea21a179f09df139032ddfce3 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Mon, 13 Mar 2023 12:59:08 +0000 Subject: [PATCH 2/2] fix tests --- .../webpack/sentryWebpackPlugin.test.ts | 34 ------------------- 1 file changed, 34 deletions(-) diff --git a/packages/nextjs/test/config/webpack/sentryWebpackPlugin.test.ts b/packages/nextjs/test/config/webpack/sentryWebpackPlugin.test.ts index fce1b852395e..bc6b8dd458a1 100644 --- a/packages/nextjs/test/config/webpack/sentryWebpackPlugin.test.ts +++ b/packages/nextjs/test/config/webpack/sentryWebpackPlugin.test.ts @@ -240,40 +240,6 @@ describe('Sentry webpack plugin config', () => { false, true, ], - [ - 'disables the plugin in Vercel `preview` environment', - exportedNextConfig, - { VERCEL_ENV: 'preview' }, - false, - false, - ], - [ - 'disables the plugin in Vercel `development` environment', - exportedNextConfig, - { VERCEL_ENV: 'development' }, - false, - false, - ], - [ - 'allows `disableClientWebpackPlugin = false` to override env vars`', - { - ...exportedNextConfig, - sentry: { disableClientWebpackPlugin: false }, - }, - { VERCEL_ENV: 'preview' }, - false, - true, - ], - [ - 'allows `disableServerWebpackPlugin = false` to override env vars`', - { - ...exportedNextConfig, - sentry: { disableServerWebpackPlugin: false }, - }, - { VERCEL_ENV: 'preview' }, - true, - false, - ], ])( '%s', async (