Skip to content

feat(core): Emit hooks for transaction start/finish #7387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2023
Merged

feat(core): Emit hooks for transaction start/finish #7387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6e1d59
feat(core): Emit hooks for transaction start/finish
AbhiPrasad Mar 8, 2023
62181ed
fix types
AbhiPrasad Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/core/src/tracing/hubextensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@ The transaction will not be sampled. Please use the ${configInstrumenter} instru
if (transaction.sampled) {
transaction.initSpanRecorder(options._experiments && (options._experiments.maxSpans as number));
}
if (client && client.emit) {
client.emit('startTransaction', transaction);
}
return transaction;
}

Expand Down Expand Up @@ -213,6 +216,9 @@ export function startIdleTransaction(
if (transaction.sampled) {
transaction.initSpanRecorder(options._experiments && (options._experiments.maxSpans as number));
}
if (client && client.emit) {
client.emit('startTransaction', transaction);
}
return transaction;
}

Expand Down
6 changes: 5 additions & 1 deletion packages/core/src/tracing/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,15 @@ export class Transaction extends SpanClass implements TransactionInterface {
// just sets the end timestamp
super.finish(endTimestamp);

const client = this._hub.getClient();
if (client && client.emit) {
client.emit('finishTransaction', this);
}

if (this.sampled !== true) {
// At this point if `sampled !== true` we want to discard the transaction.
__DEBUG_BUILD__ && logger.log('[Tracing] Discarding transaction because its trace was not chosen to be sampled.');

const client = this._hub.getClient();
if (client) {
client.recordDroppedEvent('sample_rate', 'transaction');
}
Expand Down