From 5b660cc350086218a60bc3de988ada679b100fe3 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Mon, 20 Feb 2023 15:45:00 +0100 Subject: [PATCH 1/2] feat(loader): Make lazy-loading configurable --- packages/browser/src/loader.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/browser/src/loader.js b/packages/browser/src/loader.js index 48029e7aec46..c870130cd25d 100644 --- a/packages/browser/src/loader.js +++ b/packages/browser/src/loader.js @@ -9,9 +9,10 @@ _namespace, _publicKey, _sdkBundleUrl, - _config + _config, + _lazy ) { - var lazy = true; + var lazy = _lazy; var forceLoad = false; for (var i = 0; i < document.scripts.length; i++) { @@ -217,4 +218,4 @@ } })(window, document, 'script', 'onerror', 'onunhandledrejection', 'Sentry', 'loader.js', '../../build/bundles/bundle.js', { dsn: 'https://public@example.com/1' -}); +}, true); From f09a96582a89ccdfd960fa78d74c1f651c4ff6ad Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Thu, 23 Feb 2023 16:11:46 +0100 Subject: [PATCH 2/2] address PR review feedback --- packages/browser/src/loader.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/browser/src/loader.js b/packages/browser/src/loader.js index c870130cd25d..4289d96a8fc7 100644 --- a/packages/browser/src/loader.js +++ b/packages/browser/src/loader.js @@ -17,7 +17,11 @@ for (var i = 0; i < document.scripts.length; i++) { if (document.scripts[i].src.indexOf(_publicKey) > -1) { - lazy = !(document.scripts[i].getAttribute('data-lazy') === 'no'); + // If lazy was set to true above, we need to check if the user has set data-lazy="no" + // to confirm that we should lazy load the CDN bundle + if (lazy && document.scripts[i].getAttribute('data-lazy') === 'no') { + lazy = false; + } break; } }