From 8ed8b75be7a6db43ff7a14a5c8664bdd1f021021 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Wed, 8 Feb 2023 15:30:45 +0100 Subject: [PATCH 1/2] feat(replay): Improve ignoring of rrweb-internal errors This updates rrweb to https://github.com/getsentry/rrweb/releases/tag/1.101.0, which mainly improves our wrapping of rrweb errors. --- packages/replay/package.json | 2 +- yarn.lock | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/replay/package.json b/packages/replay/package.json index ba2cec793a94..153e0e78c4cd 100644 --- a/packages/replay/package.json +++ b/packages/replay/package.json @@ -46,7 +46,7 @@ "homepage": "https://docs.sentry.io/platforms/javascript/session-replay/", "devDependencies": { "@babel/core": "^7.17.5", - "@sentry-internal/rrweb": "1.100.2", + "@sentry-internal/rrweb": "1.101.2", "@types/pako": "^2.0.0", "jsdom-worker": "^0.2.1", "pako": "^2.0.4", diff --git a/yarn.lock b/yarn.lock index 4b5d41be9c3b..b7d694549c51 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3139,17 +3139,17 @@ semver "7.3.2" semver-intersect "1.4.0" -"@sentry-internal/rrweb-snapshot@1.100.2": - version "1.100.2" - resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-snapshot/-/rrweb-snapshot-1.100.2.tgz#982b239d67872da5eb31d7d466815d4a05680450" - integrity sha512-6EvrPBPTlSD21lhDX20gxN3hnU4xj5hMLO5K4F0B1kPNVKXs1Mtf1nbpHYoIyU/67fZKmRuw/qlCjZykecXXBQ== +"@sentry-internal/rrweb-snapshot@1.101.2": + version "1.101.2" + resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-snapshot/-/rrweb-snapshot-1.101.2.tgz#cf73629374812f110ab7271f9da65f1afc6c08c3" + integrity sha512-wbc/lQ4ta7zXZGFU3sFfTz8PVcfOTeI2H2l2bo4BehZiQEEDTrqhGSFe5Nzq6Noi38CZyPT0kweGI4fUk1u0KQ== -"@sentry-internal/rrweb@1.100.2": - version "1.100.2" - resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb/-/rrweb-1.100.2.tgz#3403161925d0e4778d58033ba93766b6d261736a" - integrity sha512-MtB2fpmc7XHCwS6JdjAEJsKO/0C/VmFxI1I4o+qIjWHOEpOF1nBYZ/RSE1BadEwgGjWlU8Hp0eWUBvSBDTF8sg== +"@sentry-internal/rrweb@1.101.2": + version "1.101.2" + resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb/-/rrweb-1.101.2.tgz#65e5d80745e1c01c2f66031fb807b36837283944" + integrity sha512-IaDgoo9kxnwC6xn25yLU0ymKLVBAWGEH90iMdweTC7Izhza6k4oTy01t4/wy7ORCnfCeHZYJ4gkNJJyi4J1XHQ== dependencies: - "@sentry-internal/rrweb-snapshot" "1.100.2" + "@sentry-internal/rrweb-snapshot" "1.101.2" "@types/css-font-loading-module" "0.0.7" "@xstate/fsm" "^1.4.0" base64-arraybuffer "^1.0.1" From 52f2a07b2af934bcdd1aff8c46092ef630ebc3eb Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Thu, 9 Feb 2023 10:27:58 +0100 Subject: [PATCH 2/2] fix: never skip dependency cache --- .github/workflows/build.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0c2c7c050404..90a9657b0938 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -164,11 +164,9 @@ jobs: id: compute_lockfile_hash run: echo "hash=${{ hashFiles('yarn.lock') }}" >> "$GITHUB_OUTPUT" - # When the `ci-skip-cache` label is added to a PR, we always want to skip dependency cache - name: Check dependency cache uses: actions/cache@v3 id: cache_dependencies - if: needs.job_get_metadata.outputs.force_skip_cache == 'false' with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ steps.compute_lockfile_hash.outputs.hash }}