From cfe9e904c632134c6173f6e341e862f6026e16ac Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Tue, 17 Jan 2023 18:12:28 +0100 Subject: [PATCH 1/2] fix(react): Add children prop for Profiler --- packages/react/src/profiler.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/react/src/profiler.tsx b/packages/react/src/profiler.tsx index d4c0f0a277e4..bf9503b8232d 100644 --- a/packages/react/src/profiler.tsx +++ b/packages/react/src/profiler.tsx @@ -23,6 +23,8 @@ export type ProfilerProps = { includeUpdates?: boolean; // props given to component being profiled. updateProps: { [key: string]: unknown }; + + children: React.ReactNode; }; /** @@ -120,7 +122,6 @@ class Profiler extends React.Component { } public render(): React.ReactNode { - // eslint-disable-next-line react/prop-types return this.props.children; } } From f9d1edd6970595db5e2c4ad113407f647ce8547a Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Tue, 17 Jan 2023 18:35:15 +0100 Subject: [PATCH 2/2] make children optional --- packages/react/src/profiler.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react/src/profiler.tsx b/packages/react/src/profiler.tsx index bf9503b8232d..643ca818ca75 100644 --- a/packages/react/src/profiler.tsx +++ b/packages/react/src/profiler.tsx @@ -21,10 +21,10 @@ export type ProfilerProps = { includeRender?: boolean; // If component updates should be displayed as spans. True by default. includeUpdates?: boolean; + // Component that is being profiled. + children?: React.ReactNode; // props given to component being profiled. updateProps: { [key: string]: unknown }; - - children: React.ReactNode; }; /** @@ -137,7 +137,7 @@ class Profiler extends React.Component { function withProfiler

>( WrappedComponent: React.ComponentType

, // We do not want to have `updateProps` given in options, it is instead filled through the HOC. - options?: Pick, Exclude>, + options?: Pick, Exclude>, ): React.FC

{ const componentDisplayName = (options && options.name) || WrappedComponent.displayName || WrappedComponent.name || UNKNOWN_COMPONENT;