Skip to content

test(nextjs): Disable doubleEndMethodOnVercel on Node 10 #6792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 16, 2023
Merged

test(nextjs): Disable doubleEndMethodOnVercel on Node 10 #6792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5190303
test(nextjs): Disable `doubleEndMethodOnVercel` on Node 10
AbhiPrasad Jan 16, 2023
b130a31
correct name of func
AbhiPrasad Jan 16, 2023
fb93e33
use node version from env variables
AbhiPrasad Jan 16, 2023
c8bb893
use node major version
AbhiPrasad Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/nextjs/test/integration/test/server/doubleEndMethodOnVercel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ const { getAsync } = require('../utils/server');
// `res.send` multiple times in one request handler.
// https://github.com/getsentry/sentry-javascript/issues/6670
module.exports = async ({ url: urlBase }) => {
if (process.env.NODE_MAJOR === '10') {
console.log('not running doubleEndMethodOnVercel test on Node 10');
return;
}
const response = await getAsync(`${urlBase}/api/doubleEndMethodOnVercel`);
assert.equal(response, '{"success":true}');
};
1 change: 1 addition & 0 deletions packages/nextjs/test/run-integration-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ for NEXTJS_VERSION in 10 11 12 13; do
# having to pass this value from function to function to function to the one spot, deep in some callstack, where we
# actually need it
export NEXTJS_VERSION=$NEXTJS_VERSION
export NODE_MAJOR=$NODE_MAJOR

# Next 10 requires at least Node v10
if [ "$NODE_MAJOR" -lt "10" ]; then
Expand Down