Skip to content

ref(replay): Remove circular @sentry/browser peerDependency #6736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

ref(replay): Remove circular @sentry/browser peerDependency #6736

merged 1 commit into from
Jan 12, 2023

Conversation

@mydea
Copy link
Member

@mydea mydea commented Jan 11, 2023

We have only been using this in tests, and can use our own client instead here.

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Jan 11, 2023
@mydea mydea requested review from Lms24 and billyvg January 11, 2023 15:26
@mydea mydea self-assigned this Jan 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.13 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.33 KB (0%)

@mydea
ref(replay): Remove circular @sentry/browser peerDependency
2bc15ef 
We have only been using this in tests, and can use our own client instead here.
@mydea mydea force-pushed the fn/remove-replay-browser-dep branch from c66596d to 2bc15ef Compare January 12, 2023 09:10
@mydea mydea merged commit 476f51b into master Jan 12, 2023
@mydea mydea deleted the fn/remove-replay-browser-dep branch January 12, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billyvg billyvg billyvg approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels

Package: replay Issues related to the Sentry Replay SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mydea @billyvg @Lms24