ref(nextjs): Completely deprecate isBuild() and IS_BUILD
#6727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
commented
Jan 11, 2023
Comment on lines
-27
to
-32
| // Exporting this constant means we can compute it without the linter complaining, even if we stop directly using it in | ||
| // this file. It's important that it be computed as early as possible, because one of its indicators is seeing 'build' | ||
| // (as in the CLI command `next build`) in `process.argv`. Later on in the build process, everything's been spun out | ||
| // into child threads and `argv` turns into ['node', 'path/to/childProcess.js'], so the original indicator is lost. We | ||
| // thus want to compute it as soon as the SDK is loaded for the first time, which is normally when the user imports | ||
| // `withSentryConfig` into `next.config.js`. |
Contributor
Author
There was a problem hiding this comment.
This comment was only applicable back when we had instrumentServer which we recently removed.
mydea
approved these changes
Jan 11, 2023
Contributor
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense that we export any of this functionality so let's just completely deprecate it and remove it in the next major.