Skip to content

fix(nextjs): Pass this through wrappers #6572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2022
Merged

fix(nextjs): Pass this through wrappers #6572

merged 3 commits into from
Dec 16, 2022

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Dec 16, 2022 •
edited
Loading

Fixes #6479

Our Next.js wrapping methods didn't take care of correctly passing this context. This PR fixes that.

@lforst lforst requested review from AbhiPrasad, Lms24 and mydea December 16, 2022 13:19
@lforst lforst marked this pull request as ready for review December 16, 2022 13:28
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.78 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.27 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.57 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.8 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.34 KB (+0.02% 🔺)
@sentry/browser - Webpack (minified) 66.48 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.36 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.56 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.76 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.19 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.08 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.13 KB (0%)

Lms24
Lms24 approved these changes Dec 16, 2022
View reviewed changes
@lforst lforst merged commit 2fa11eb into master Dec 16, 2022
@lforst lforst deleted the lforst-fix-nextjs-wrapper-this-context branch December 16, 2022 13:54
@pckilgore pckilgore mentioned this pull request Feb 24, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Next.js _document.tsx implmentation broken since version 7.17.0

3 participants

@lforst @Lms24