From 7f21c3a3dafa1f8962640626a704ba3cfc214c0d Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Wed, 7 Dec 2022 11:56:11 +0100 Subject: [PATCH 1/2] fix(replay): Add CDN bundle path to release artifacts --- .github/workflows/build.yml | 1 + docs/new-sdk-release-checklist.md | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 188ed83b4878..438e521472d1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -344,6 +344,7 @@ jobs: ${{ github.workspace }}/packages/browser/build/bundles/** ${{ github.workspace }}/packages/integrations/build/bundles/** ${{ github.workspace }}/packages/tracing/build/bundles/** + ${{ github.workspace }}/packages/replay/build/bundles/** ${{ github.workspace }}/packages/**/*.tgz job_unit_test: diff --git a/docs/new-sdk-release-checklist.md b/docs/new-sdk-release-checklist.md index 819a30f3d664..50f3affc0009 100644 --- a/docs/new-sdk-release-checklist.md +++ b/docs/new-sdk-release-checklist.md @@ -40,6 +40,10 @@ This page serves as a checklist of what to do when releasing a new SDK for the f - [ ] Ensure dependent packages are correctly set for “Determine changed packages” - [ ] Ensure unit tests run correctly +- [ ] Make sure the file paths in the ["Uplad Artifacts" job](https://github.com/getsentry/sentry-javascript/blob/e5c1486eed236b878f2c49d6a04be86093816ac9/.github/workflows/build.yml#L314-L349) in `build.yml` include your new artifacts. + - **This is especially important, if you're adding new CDN bundles!** + - Tarballs (*.tgz archives) should work OOTB + ## Cutting the Release When you’re ready to make the first release, there are a couple of steps that need to be performed in the **correct order**. Note that you can prepare the PRs at any time but the **merging oder** is important: From 0c0e38338583f6290b015406c8cccceeefb042c4 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Wed, 7 Dec 2022 12:09:15 +0100 Subject: [PATCH 2/2] Update docs/new-sdk-release-checklist.md Co-authored-by: Abhijeet Prasad --- docs/new-sdk-release-checklist.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/new-sdk-release-checklist.md b/docs/new-sdk-release-checklist.md index 50f3affc0009..5e795b19e18d 100644 --- a/docs/new-sdk-release-checklist.md +++ b/docs/new-sdk-release-checklist.md @@ -40,7 +40,7 @@ This page serves as a checklist of what to do when releasing a new SDK for the f - [ ] Ensure dependent packages are correctly set for “Determine changed packages” - [ ] Ensure unit tests run correctly -- [ ] Make sure the file paths in the ["Uplad Artifacts" job](https://github.com/getsentry/sentry-javascript/blob/e5c1486eed236b878f2c49d6a04be86093816ac9/.github/workflows/build.yml#L314-L349) in `build.yml` include your new artifacts. +- [ ] Make sure the file paths in the ["Upload Artifacts" job](https://github.com/getsentry/sentry-javascript/blob/e5c1486eed236b878f2c49d6a04be86093816ac9/.github/workflows/build.yml#L314-L349) in `build.yml` include your new artifacts. - **This is especially important, if you're adding new CDN bundles!** - Tarballs (*.tgz archives) should work OOTB