Skip to content

fix(remix): Prevent crashes from failed normalizeRemixRequest calls. #6296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2022
Merged

fix(remix): Prevent crashes from failed normalizeRemixRequest calls. #6296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions packages/remix/src/utils/instrumentServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,13 @@ async function captureRemixServerException(err: Error, name: string, request: Re
return;
}

const normalizedRequest = normalizeRemixRequest(request as unknown as any);
let normalizedRequest: Record<string, unknown> = request as unknown as any;

try {
normalizedRequest = normalizeRemixRequest(request as unknown as any);
} catch (e) {
__DEBUG_BUILD__ && logger.warn('Failed to normalize Remix request');
}

captureException(isResponse(err) ? await extractResponseError(err) : err, scope => {
const activeTransactionName = getActiveTransaction()?.name;
Expand Down Expand Up @@ -389,7 +395,13 @@ function wrapRequestHandler(origRequestHandler: RequestHandler, build: ServerBui
const options = hub.getClient()?.getOptions();
const scope = hub.getScope();

const normalizedRequest = normalizeRemixRequest(request);
let normalizedRequest: Record<string, unknown> = request;

try {
normalizedRequest = normalizeRemixRequest(request);
} catch (e) {
__DEBUG_BUILD__ && logger.warn('Failed to normalize Remix request');
}

const url = new URL(request.url);
const [name, source] = getTransactionName(routes, url, pkg);
Expand Down