From 3516b0cf85b96490e0e0a3132736834ae1f84563 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Tue, 22 Nov 2022 18:13:05 +0100 Subject: [PATCH 1/4] chore(otel): Update installation instructions --- packages/opentelemetry-node/README.md | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/packages/opentelemetry-node/README.md b/packages/opentelemetry-node/README.md index 75ddaf87906d..736f91035533 100644 --- a/packages/opentelemetry-node/README.md +++ b/packages/opentelemetry-node/README.md @@ -35,15 +35,25 @@ Note that `@sentry/opentelemetry-node` depends on the following peer dependencie You need to register the `SentrySpanProcessor` and `SentryPropagator` with your OpenTelemetry installation: ```js -import * as Sentry from '@sentry/node'; -import { SentrySpanProcessor } from '@sentry/opentelemetry-node'; -import * as otelApi from '@opentelemetry/api'; -import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node'; -import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-grpc'; +const Sentry = require("@sentry/node"); +const { + SentrySpanProcessor, + SentryPropagator, +} = require("@sentry/opentelemetry-node"); + +const opentelemetry = require("@opentelemetry/api"); +const { + getNodeAutoInstrumentations, +} = require("@opentelemetry/auto-instrumentations-node"); +const { + OTLPTraceExporter, +} = require("@opentelemetry/exporter-trace-otlp-grpc"); // Make sure to call `Sentry.init` BEFORE initializing the OpenTelemetry SDK Sentry.init({ dsn: '__DSN__', + // set the instrumenter to use OpenTelemetry instead of Sentry + instrumenter: 'otel', // ... }); @@ -56,7 +66,9 @@ const sdk = new opentelemetry.NodeSDK({ spanProcessor: new SentrySpanProcessor(), }); -otelApi.propagation.setGlobalPropagator(new SentryPropagator()); +opentelemetry.propagation.setGlobalPropagator(new SentryPropagator()); + +sdk.start(); ``` ## Links From 9a0596b4532cc033e4a000afa04ce1de3ce14dc0 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Tue, 22 Nov 2022 18:16:36 +0100 Subject: [PATCH 2/4] Update packages/opentelemetry-node/README.md --- packages/opentelemetry-node/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/opentelemetry-node/README.md b/packages/opentelemetry-node/README.md index 736f91035533..5695acfb51e9 100644 --- a/packages/opentelemetry-node/README.md +++ b/packages/opentelemetry-node/README.md @@ -41,7 +41,7 @@ const { SentryPropagator, } = require("@sentry/opentelemetry-node"); -const opentelemetry = require("@opentelemetry/api"); +const opentelemetry = require("@opentelemetry/sdk-node"); const { getNodeAutoInstrumentations, } = require("@opentelemetry/auto-instrumentations-node"); From aa63685677f988a19d84a7f4e6148e912419b407 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Tue, 22 Nov 2022 18:22:29 +0100 Subject: [PATCH 3/4] add otelApi back --- packages/opentelemetry-node/README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/opentelemetry-node/README.md b/packages/opentelemetry-node/README.md index 5695acfb51e9..99a71636a0ec 100644 --- a/packages/opentelemetry-node/README.md +++ b/packages/opentelemetry-node/README.md @@ -42,6 +42,7 @@ const { } = require("@sentry/opentelemetry-node"); const opentelemetry = require("@opentelemetry/sdk-node"); +const otelApi = require("@opentelemetry/api"); const { getNodeAutoInstrumentations, } = require("@opentelemetry/auto-instrumentations-node"); @@ -66,7 +67,7 @@ const sdk = new opentelemetry.NodeSDK({ spanProcessor: new SentrySpanProcessor(), }); -opentelemetry.propagation.setGlobalPropagator(new SentryPropagator()); +otelApi.propagation.setGlobalPropagator(new SentryPropagator()); sdk.start(); ``` From 4dd03762a8f7841bb62f1991593d4f052d6f9b00 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Tue, 22 Nov 2022 18:29:36 +0100 Subject: [PATCH 4/4] Update packages/opentelemetry-node/README.md --- packages/opentelemetry-node/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/opentelemetry-node/README.md b/packages/opentelemetry-node/README.md index 99a71636a0ec..551684a75c26 100644 --- a/packages/opentelemetry-node/README.md +++ b/packages/opentelemetry-node/README.md @@ -53,6 +53,7 @@ const { // Make sure to call `Sentry.init` BEFORE initializing the OpenTelemetry SDK Sentry.init({ dsn: '__DSN__', + tracesSampleRate: 1.0, // set the instrumenter to use OpenTelemetry instead of Sentry instrumenter: 'otel', // ...