fix(integrations): Remove erroneous WINDOW exports #6185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Nov 10, 2022
AbhiPrasad
changed the title
Collaborator
Author
|
I could add some TypeScript tests that will avoid this from happening again but they will become redundant once the code gets moved and node/dom types get fully enforced across packages. |
Member
We could add a new recipe to https://github.com/getsentry/sentry-javascript/tree/master/packages/e2e-tests, but I would do that in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6183
These ended up in the TypeScript definitions because they are exported but they should never have been exported!