Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Oct 27, 2022

This is a draft of an idea to only run CI for a package if that package was actually affected by changes.

Basically, the logic is:

If this is something we'd like to explore, I need to actually verify that this works as expected 😅 But in theory it appears straightforward.

@mydea mydea self-assigned this Oct 27, 2022
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try using https://github.com/getsentry/paths-filter, seems other folks at Sentry are using this.

Might help with the nextjs tests not running all the time.

@mydea
Copy link
Member Author

mydea commented Nov 2, 2022

I think we should try using https://github.com/getsentry/paths-filter, seems other folks at Sentry are using this.

Might help with the nextjs tests not running all the time.

While that looks nice, as far as I can see that does not check dependencies of packages - e.g. you need to explicitly define, for the ember example, something like:

- uses: dorny/paths-filter@v2
  id: changes
  with:
    filters: |
      src:
        - 'packages/ember/**'
        - 'packages/utils/**'
        - 'packages/browser/**'
        - etc

Which of course works, but means we need to make sure to keep this in sync everywhere. But we could also pretty easily get started with such an approach, at least for specific things like nextjs.

@mydea mydea closed this Nov 7, 2022
@mydea mydea deleted the fn/only-run-tests-ember branch November 9, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants