fix(vue): Don't overwrite custom transaction names of pageload transactions #6060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
AbhiPrasad and
lobsterkatie
and removed request for
a team
Lms24
commented
Oct 27, 2022
Comment on lines
+95
to
99
| if (pageloadTransaction.metadata.source !== 'custom') { | ||
| pageloadTransaction.setName(transactionName, transactionSource); | ||
| } | ||
| pageloadTransaction.setData('params', data.params); | ||
| pageloadTransaction.setData('query', data.query); |
Member
Author
There was a problem hiding this comment.
I guess there's an argument to be made that if we have a custom source here, we don't need to set the params and query data. Happy to change this if reviewers prefer that.
Member
There was a problem hiding this comment.
I'm generally of the school of thought that (within reason) more data is better. We've been sending it before now, so I vote that we keep doing so.
Member
Author
There was a problem hiding this comment.
Good point. Then I'll keep it as is
Lms24
changed the title
Contributor
size-limit report 📦
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As brought to our attention in #6048, our pageload transaction start change (which makes the transaction start earlier) introduced in #5983 caused custom transaction names to be overwritten when
beforeNavigateis used to update the transaction name.This patch fixes this problem by checking for the transaction source before (not) updating the current transaction name with the resolved route name once the router's
beforeEachhook was called. Furthermore, it adds a test to cover this case.See #6048 (comment) for the motivation for creating this PR.
fixes #6047