From 04ec2ec0fadd9e7bf11d26a7623070851f881b28 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Mon, 17 Oct 2022 15:41:00 -0700 Subject: [PATCH 1/3] use `setup-node` v3 --- .github/workflows/build.yml | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7a4b458da97a..790a727df7ae 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -78,7 +78,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ env.DEFAULT_NODE_VERSION }} # we use a hash of yarn.lock as our cache key, because if it hasn't changed, our dependencies haven't changed, @@ -109,7 +109,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: # ember won't build under node 16, at least not with the versions of the ember build tools we use node-version: '14' @@ -148,7 +148,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache @@ -191,7 +191,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: # The size limit action runs `yarn` and `yarn build` when this job is executed on # `master`. We can't change this without making changes to the action, so we'll @@ -228,7 +228,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache @@ -255,7 +255,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache @@ -283,7 +283,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache @@ -323,7 +323,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} - name: Check dependency cache @@ -360,7 +360,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} - name: Check dependency cache @@ -402,7 +402,7 @@ jobs: # well, we can pull it out. fetch-depth: 0 - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: # The only danger with Ember in terms of Node versions is that the build tool, ember-cli, won't work if Node # is too old. Since Oct 2019, Node 10 has been the oldest version supported by ember-cli, so test against @@ -455,7 +455,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache @@ -495,7 +495,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache @@ -528,7 +528,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache @@ -565,7 +565,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} - name: Check dependency cache @@ -600,7 +600,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} - name: Check dependency cache @@ -632,7 +632,7 @@ jobs: with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache From 577c29960b25f6db5e6a32d7b04b0b3487662359 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Mon, 17 Oct 2022 15:42:47 -0700 Subject: [PATCH 2/3] use `checkout` v3 --- .github/workflows/build.yml | 34 +++++++++++++-------------- .github/workflows/canary.yml | 2 +- .github/workflows/codeql-analysis.yml | 2 +- .github/workflows/release.yml | 2 +- 4 files changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 790a727df7ae..65a95bfa1e3f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -50,7 +50,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out current commit - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} # We need to check out not only the fake merge commit between the PR and the base branch which GH creates, but @@ -74,7 +74,7 @@ jobs: timeout-minutes: 15 steps: - name: 'Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})' - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -105,7 +105,7 @@ jobs: timeout-minutes: 20 steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -144,7 +144,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -187,7 +187,7 @@ jobs: if: ${{ github.event_name == 'pull_request' }} || ${{ startsWith(github.ref, 'refs/heads/master/') }} steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -224,7 +224,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -251,7 +251,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -279,7 +279,7 @@ jobs: if: startsWith(github.ref, 'refs/heads/release/') steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -319,7 +319,7 @@ jobs: node: [8, 10, 12, 14, 16, 18] steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -356,7 +356,7 @@ jobs: node: [10, 12, 14, 16, 18] steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -393,7 +393,7 @@ jobs: scenario: [ember-release, ember-beta, ember-classic, ember-lts-3.24] steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} # TODO: removing `fetch-depth` below seems to have no effect, and the commit which added it had no description, @@ -451,7 +451,7 @@ jobs: tracing_only: false steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -491,7 +491,7 @@ jobs: - WebkitHeadless steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -524,7 +524,7 @@ jobs: continue-on-error: true steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -561,7 +561,7 @@ jobs: node: [10, 12, 14, 16, 18] steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -596,7 +596,7 @@ jobs: node: [14, 16, 18] steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node @@ -628,7 +628,7 @@ jobs: continue-on-error: true steps: - name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }}) - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node diff --git a/.github/workflows/canary.yml b/.github/workflows/canary.yml index e0d92547708e..2e431e0f7359 100644 --- a/.github/workflows/canary.yml +++ b/.github/workflows/canary.yml @@ -23,7 +23,7 @@ jobs: timeout-minutes: 30 steps: - name: 'Check out current commit' - uses: actions/checkout@v2 + uses: actions/checkout@v3 with: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index a684b8bfde14..36541c3b9943 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -41,7 +41,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 8e02b82e9da1..92239b35aa43 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -16,7 +16,7 @@ jobs: runs-on: ubuntu-latest name: 'Release a new version' steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: token: ${{ secrets.GH_RELEASE_PAT }} fetch-depth: 0 From d808baa684c9116c06e4a6042292f016ae542ee8 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Mon, 17 Oct 2022 16:37:44 -0700 Subject: [PATCH 3/3] use `cache` v3 --- .github/workflows/build.yml | 62 ++++++++++++++++++------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 65a95bfa1e3f..0da365f783f6 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -87,7 +87,7 @@ jobs: id: compute_lockfile_hash run: echo "hash=${{ hashFiles('yarn.lock') }}" >> "$GITHUB_OUTPUT" - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 id: cache_dependencies with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} @@ -114,12 +114,12 @@ jobs: # ember won't build under node 16, at least not with the versions of the ember build tools we use node-version: '14' - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_install_deps.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 id: cache_built_packages with: path: ${{ env.CACHED_BUILD_PATHS }} @@ -152,12 +152,12 @@ jobs: with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -198,12 +198,12 @@ jobs: # use Node 14 for now. node-version: '14' - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -232,12 +232,12 @@ jobs: with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -259,12 +259,12 @@ jobs: with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -287,12 +287,12 @@ jobs: with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -327,12 +327,12 @@ jobs: with: node-version: ${{ matrix.node }} - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -364,12 +364,12 @@ jobs: with: node-version: ${{ matrix.node }} - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -410,12 +410,12 @@ jobs: # tests in our Node matrix above. node-version: '10' - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -459,12 +459,12 @@ jobs: with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -499,12 +499,12 @@ jobs: with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -532,12 +532,12 @@ jobs: with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -569,12 +569,12 @@ jobs: with: node-version: ${{ matrix.node }} - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -604,12 +604,12 @@ jobs: with: node-version: ${{ matrix.node }} - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} @@ -636,12 +636,12 @@ jobs: with: node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} - name: Check build cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }}