ref(utils): Deprecate getGlobalObject as it's no longer used
#5949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Oct 13, 2022
| * | ||
| * @returns Global scope object | ||
| */ | ||
| export function getGlobalObject<T>(): T & InternalGlobal { |
Member
There was a problem hiding this comment.
For now let's deprecate this just in case, and we can remove in v8 - I know we don't have to follow semvar in utils, but getGlobalObject might be more commonly used than other functions, and doesn't cost us much to just wait.
AbhiPrasad
changed the title
getGlobalObject as it's no longer usedgetGlobalObject as it's no longer used
AbhiPrasad
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5611
This PR wraps up the changes to the global object detection by removing
getGlobalObjectwhich is no longer used.