ref(utils): Remove getGlobalObject() usage from @sentry/utils
#5831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
force-pushed
the
feat/remove-getGlobalObject-utils
branch
from
c05491a to
99a0687
Compare
This was referenced Oct 5, 2022
AbhiPrasad
approved these changes
Oct 12, 2022
| extensions?: { | ||
| /** Extension methods for the hub, which are bound to the current Hub instance */ | ||
| // eslint-disable-next-line @typescript-eslint/ban-types | ||
| [key: string]: Function; |
Member
There was a problem hiding this comment.
We should probably type this stricter, but we can do that after we are done with all of the changes.
This was referenced Oct 13, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5821 ended up being a rather huge PR so this is the first of many PRs that makes these changes per package. For now we keep the
getGlobalObject()implementation until all the packages are migrated.As discussed here, this PR:
getGlobalObjectwith a constGLOBAL_OBJwhich retains the runtime detection from feat(utils): Modern implementation ofgetGlobalObject#5809GLOBAL_OBJis always accessedWINDOWconst which returnsGLOBAL_OBJbut withtypeof GLOBAL_OBJ & Windowtype.@sentry/browserto ensure stricter typing around the global objectWINDOW_GLOBALto remove any ambiguity?