ref(eslint): Fix max lines eslint rule #5577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's debatable whether this should be enabled at all, but at the very least we should relax the conditions that don't affect bundle size, such as blank lines and comments since it leads towards either disabling the rule entirely (as you can see in a lot of sdk files) or people not writing comments (again, not ideal).
AbhiPrasad
changed the title
AbhiPrasad
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's debatable whether this should be enabled at all, but at the very least we should relax the conditions that don't affect bundle size, such as blank lines and comments since it leads towards either disabling the rule entirely (as you can see in a lot of sdk files) or people not writing comments (again, not ideal).