Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Jun 28, 2022

Since we re-enabled the "Size Check" job for GHA runs on master in #5314, our CI runs were failing because the "Size Check" job was failing. The reason is that our size-limit-action is not passing on the skip_step option we set here

if it is executed on the master branch. Instead, null is passed to the execution function of the action which makes the action first call yarn install followed by yarn build. This fails because the Ember SDK cannot be built with Node 16.

While the best option to fix this is to make changes to the actions to respect the skip_step option on master runs, we want to fix things on our end for now which should work by setting the Node version to 14.

@Lms24 Lms24 requested a review from lforst June 28, 2022 09:51
@Lms24 Lms24 self-assigned this Jun 28, 2022
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.3 KB (added)
@sentry/browser - ES5 CDN Bundle (minified) 59.72 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.9 KB (added)
@sentry/browser - ES6 CDN Bundle (minified) 52.67 KB (added)
@sentry/browser - Webpack (gzipped + minified) 19.67 KB (added)
@sentry/browser - Webpack (minified) 64.04 KB (added)
@sentry/react - Webpack (gzipped + minified) 19.69 KB (added)
@sentry/nextjs Client - Webpack (gzipped + minified) 43.85 KB (added)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.63 KB (added)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.9 KB (added)

@Lms24 Lms24 merged commit 519dc6c into master Jun 28, 2022
@Lms24 Lms24 deleted the lms-fix-size-limit-job branch June 28, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants