fix(build): Use Node 14 in "Size Check" job to fix CI runs on master #5324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we re-enabled the "Size Check" job for GHA runs on
masterin #5314, our CI runs were failing because the "Size Check" job was failing. The reason is that our size-limit-action is not passing on theskip_stepoption we set heresentry-javascript/.github/workflows/build.yml
Line 210 in 05cb748
if it is executed on the master branch. Instead,
nullis passed to the execution function of the action which makes the action first callyarn installfollowed byyarn build. This fails because the Ember SDK cannot be built with Node 16.While the best option to fix this is to make changes to the actions to respect the
skip_stepoption on master runs, we want to fix things on our end for now which should work by setting the Node version to 14.