From 012d7ed4997025387a01e2b7cd97a784187af985 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Thu, 5 May 2022 01:36:11 -0700 Subject: [PATCH 1/2] add default node version to CI --- .github/workflows/build.yml | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 155126752160..0d3d37e8a16c 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -12,6 +12,8 @@ on: required: false env: + DEFAULT_NODE_VERSION: '16' + HEAD_COMMIT: ${{ github.event.inputs.commit || github.sha }} CACHED_DEPENDENCY_PATHS: | @@ -45,6 +47,8 @@ jobs: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node uses: actions/setup-node@v1 + with: + node-version: ${{ env.DEFAULT_NODE_VERSION }} # we use a hash of yarn.lock as our cache key, because if it hasn't changed, our dependencies haven't changed, # so no need to reinstall them - name: Compute dependency cache key @@ -74,6 +78,8 @@ jobs: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node uses: actions/setup-node@v1 + with: + node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache uses: actions/cache@v2 with: @@ -118,7 +124,7 @@ jobs: - name: Set up Node uses: actions/setup-node@v1 with: - node-version: '12' + node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache uses: actions/cache@v2 with: @@ -149,6 +155,8 @@ jobs: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node uses: actions/setup-node@v1 + with: + node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache uses: actions/cache@v2 with: @@ -174,6 +182,8 @@ jobs: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node uses: actions/setup-node@v1 + with: + node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache uses: actions/cache@v2 with: @@ -200,6 +210,8 @@ jobs: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node uses: actions/setup-node@v1 + with: + node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache uses: actions/cache@v2 with: @@ -367,7 +379,7 @@ jobs: - name: Set up Node uses: actions/setup-node@v1 with: - node-version: '16' + node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache uses: actions/cache@v2 with: @@ -406,6 +418,8 @@ jobs: ref: ${{ env.HEAD_COMMIT }} - name: Set up Node uses: actions/setup-node@v1 + with: + node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache uses: actions/cache@v2 with: @@ -438,7 +452,7 @@ jobs: - name: Set up Node uses: actions/setup-node@v1 with: - node-version: '16' + node-version: ${{ env.DEFAULT_NODE_VERSION }} - name: Check dependency cache uses: actions/cache@v2 with: From ac13f973e2ba0f814029916fc2ac7e436cf56e7d Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Thu, 5 May 2022 08:42:49 -0700 Subject: [PATCH 2/2] use node 14 for building --- .github/workflows/build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0d3d37e8a16c..c642bde120ff 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -79,7 +79,8 @@ jobs: - name: Set up Node uses: actions/setup-node@v1 with: - node-version: ${{ env.DEFAULT_NODE_VERSION }} + # ember won't build under node 16, at least not with the versions of the ember build tools we use + node-version: '14' - name: Check dependency cache uses: actions/cache@v2 with: