From a45590feaa3b2ae0d3374e2bea22e624321599e7 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Thu, 5 May 2022 09:19:49 +0000 Subject: [PATCH] ref: Delete unneeded `SDK_NAME` --- MIGRATION.md | 5 +++-- packages/browser/src/exports.ts | 1 - packages/browser/src/version.ts | 2 -- packages/node/src/index.ts | 1 - packages/node/src/version.ts | 2 -- packages/tracing/src/index.bundle.ts | 2 +- packages/vue/src/index.bundle.ts | 1 - 7 files changed, 4 insertions(+), 10 deletions(-) delete mode 100644 packages/browser/src/version.ts delete mode 100644 packages/node/src/version.ts diff --git a/MIGRATION.md b/MIGRATION.md index 64a795237c24..950a8ce6cea1 100644 --- a/MIGRATION.md +++ b/MIGRATION.md @@ -281,8 +281,9 @@ For our efforts to reduce bundle size of the SDK we had to remove and refactor p [#4919](https://github.com/getsentry/sentry-javascript/pull/4919)). `Backend` was an unnecessary abstraction which is not present in other Sentry SDKs. For the sake of reducing complexity, increasing consistency with other Sentry SDKs and decreasing bundle-size, `Backend` was removed. -- Remove support for Opera browser pre v15 -- Rename `UserAgent` integration to `HttpContext` (see [#5027](https://github.com/getsentry/sentry-javascript/pull/5027)) +- Remove support for Opera browser pre v15. +- Rename `UserAgent` integration to `HttpContext`. (see [#5027](https://github.com/getsentry/sentry-javascript/pull/5027)) +- Remove `SDK_NAME` export from `@sentry/browser`, `@sentry/node`, `@sentry/tracing` and `@sentry/vue` packages. ## Sentry Angular SDK Changes diff --git a/packages/browser/src/exports.ts b/packages/browser/src/exports.ts index 4055ef8e595b..ac3cea82190d 100644 --- a/packages/browser/src/exports.ts +++ b/packages/browser/src/exports.ts @@ -57,5 +57,4 @@ export { winjsStackLineParser, } from './stack-parsers'; export { defaultIntegrations, forceLoad, init, lastEventId, onLoad, showReportDialog, flush, close, wrap } from './sdk'; -export { SDK_NAME } from './version'; export { GlobalHandlers, TryCatch, Breadcrumbs, LinkedErrors, HttpContext, Dedupe } from './integrations'; diff --git a/packages/browser/src/version.ts b/packages/browser/src/version.ts deleted file mode 100644 index 462be137a6ca..000000000000 --- a/packages/browser/src/version.ts +++ /dev/null @@ -1,2 +0,0 @@ -// TODO: Remove in the next major release and rely only on @sentry/core SDK_VERSION and SdkInfo metadata -export const SDK_NAME = 'sentry.javascript.browser'; diff --git a/packages/node/src/index.ts b/packages/node/src/index.ts index ae1e38cc150d..823dc73d848e 100644 --- a/packages/node/src/index.ts +++ b/packages/node/src/index.ts @@ -46,7 +46,6 @@ export { NodeClient } from './client'; export { makeNodeTransport } from './transports'; export { defaultIntegrations, init, lastEventId, flush, close, getSentryRelease } from './sdk'; export { deepReadDirSync } from './utils'; -export { SDK_NAME } from './version'; export { defaultStackParser } from './stack-parser'; import { Integrations as CoreIntegrations } from '@sentry/core'; diff --git a/packages/node/src/version.ts b/packages/node/src/version.ts deleted file mode 100644 index 8cfd1070cec5..000000000000 --- a/packages/node/src/version.ts +++ /dev/null @@ -1,2 +0,0 @@ -// TODO: Remove in the next major release and rely only on @sentry/core SDK_VERSION and SdkMetadata -export const SDK_NAME = 'sentry.javascript.node'; diff --git a/packages/tracing/src/index.bundle.ts b/packages/tracing/src/index.bundle.ts index 05936d798a66..bb55da2cd273 100644 --- a/packages/tracing/src/index.bundle.ts +++ b/packages/tracing/src/index.bundle.ts @@ -50,7 +50,7 @@ export { close, wrap, } from '@sentry/browser'; -export { SDK_NAME, SDK_VERSION } from '@sentry/browser'; +export { SDK_VERSION } from '@sentry/browser'; import { Integrations as BrowserIntegrations } from '@sentry/browser'; import { getGlobalObject } from '@sentry/utils'; diff --git a/packages/vue/src/index.bundle.ts b/packages/vue/src/index.bundle.ts index 690731711855..57059e55e80c 100644 --- a/packages/vue/src/index.bundle.ts +++ b/packages/vue/src/index.bundle.ts @@ -43,7 +43,6 @@ export { makeFetchTransport, makeXHRTransport, withScope, - SDK_NAME, SDK_VERSION, } from '@sentry/browser';