Skip to content

fix(tests): Use non-delayed success endpoints to test erroneous cases. #4937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2022
Merged

fix(tests): Use non-delayed success endpoints to test erroneous cases. #4937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/node-integration-tests/suites/sessions/crashed-session-aggregate/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ test('should aggregate successful and crashed sessions', async () => {
const envelope = await Promise.race([
getEnvelopeRequest(`${url}/success`),
getEnvelopeRequest(`${url}/error_unhandled`),
getEnvelopeRequest(`${url}/success_slow`),
getEnvelopeRequest(`${url}/success_next`),
]);

expect(envelope).toHaveLength(3);
Expand Down
2 changes: 1 addition & 1 deletion packages/node-integration-tests/suites/sessions/errored-session-aggregate/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ test('should aggregate successful, crashed and erroneous sessions', async () =>
const url = await runServer(__dirname, `${path.resolve(__dirname, '..')}/server.ts`);

const envelope = await Promise.race([
getEnvelopeRequest(`${url}/success_slow`),
getEnvelopeRequest(`${url}/success`),
getEnvelopeRequest(`${url}/error_handled`),
getEnvelopeRequest(`${url}/error_unhandled`),
]);
Expand Down
3 changes: 1 addition & 2 deletions packages/node-integration-tests/suites/sessions/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ clearInterval(flusherIntervalId);
// @ts-ignore: need access to `_intervalId`
flusherIntervalId = flusher?._intervalId = setInterval(() => flusher?.flush(), 1000);

// @ts-ignore: need access to `_intervalId` again
setTimeout(() => clearInterval(flusherIntervalId), 3000);
setTimeout(() => clearInterval(flusherIntervalId), 2000);

app.get('/test/success', (_req, res) => {
res.send('Success!');
Expand Down