From 7fb1e4c1cd5f3ca59907783b12fc5155a7ca298e Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Mon, 4 Apr 2022 11:23:33 -0400 Subject: [PATCH 1/2] fix(build): Find release branches correctly Use `refs/heads/release/` instead of `release` when comparing against `github.ref` to see if size-check should be run. Needed to unblock next release. --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 726b415ab1b8..1c1cd36cc205 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -124,7 +124,7 @@ jobs: - name: Check bundle sizes uses: getsentry/size-limit-action@v4 # Don't run size check on release branches - at that point, we're already committed - if: ${{ !startsWith(github.ref, 'release') }} + if: ${{ !startsWith(github.ref, 'refs/heads/release/') != true with: github_token: ${{ secrets.GITHUB_TOKEN }} skip_step: build From d75c051c94bf840642e9d3b6b9780cc0368643e6 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Mon, 4 Apr 2022 11:27:15 -0400 Subject: [PATCH 2/2] Update .github/workflows/build.yml --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1c1cd36cc205..d13135308ce0 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -124,7 +124,7 @@ jobs: - name: Check bundle sizes uses: getsentry/size-limit-action@v4 # Don't run size check on release branches - at that point, we're already committed - if: ${{ !startsWith(github.ref, 'refs/heads/release/') != true + if: ${{ !startsWith(github.ref, 'refs/heads/release/') }} with: github_token: ${{ secrets.GITHUB_TOKEN }} skip_step: build