ref(utils): Introduce getEnvelopeType helper #4751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify new transport send by grabbing the envelope category from the envelope instead of passing it in explicitly.
AbhiPrasad
requested review from
a team,
lforst and
lobsterkatie
and removed request for
a team
Contributor
size-limit report
|
lforst
approved these changes
Mar 22, 2022
packages/core/src/transports/base.ts
Outdated
|
|
||
| function send(envelope: Envelope, category: TransportCategory): PromiseLike<TransportResponse> { | ||
| function send(envelope: Envelope): PromiseLike<TransportResponse> { | ||
| const category = getEnvelopeType(envelope) as TransportCategory; |
Contributor
There was a problem hiding this comment.
Naive question because I'm not too familiar with envelopes yet: Would it make sense to change the return type of getEnvelopeType to be more strict instead of casting here?
Member
Author
There was a problem hiding this comment.
Changed to make this more clear!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify new transport send by grabbing the envelope category from the
envelope instead of passing it in explicitly.