fix(ember): Fix merging env config #4714
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously getting config from macros looks to be potentially pulling a fresh object instance in prod mode, which means the previous assign into the object no longer applies, and if the config didn't have a Sentry entry the initialize would crash. This should hopefully fix this issue for those no longer using config.
Contributor
size-limit report
|
AbhiPrasad
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously getting config from macros looks to be potentially pulling a fresh object instance in prod mode, which means the previous assign into the object no longer applies, and if the config didn't have a Sentry entry the initialize would crash. This should hopefully fix this issue for those no longer using env config.
Fixes #4015