Skip to content

fix(browser): Use apply rather than call in try-catch integration #4695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022
Merged

fix(browser): Use apply rather than call in try-catch integration #4695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/browser/src/integrations/trycatch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,7 @@ function _wrapRAF(original: any): (callback: () => void) => any {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
return function (this: any, callback: () => void): () => void {
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
return original.call(
this,
return original.apply(this, [
wrap(callback, {
mechanism: {
data: {
Expand All @@ -140,7 +139,7 @@ function _wrapRAF(original: any): (callback: () => void) => any {
type: 'instrument',
},
}),
);
]);
};
}

Expand Down Expand Up @@ -225,8 +224,7 @@ function _wrapEventTarget(target: string): void {
// can sometimes get 'Permission denied to access property "handle Event'
}

return original.call(
this,
return original.apply(this, [
eventName,
// eslint-disable-next-line @typescript-eslint/no-explicit-any
wrap(fn as any as WrappedFunction, {
Expand All @@ -241,7 +239,7 @@ function _wrapEventTarget(target: string): void {
},
}),
options,
);
]);
};
});

Expand Down