Skip to content

refactor(dsn): improve invalid dsn error message #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2022
Merged

refactor(dsn): improve invalid dsn error message #4430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/utils/src/dsn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function dsnFromString(str: string): DsnComponents {
const match = DSN_REGEX.exec(str);

if (!match) {
throw new SentryError('Invalid Dsn');
throw new SentryError(`Invalid Sentry Dsn: ${str}`);
}

const [protocol, publicKey, pass = '', host, port = '', lastPath] = match.slice(1);
Expand Down Expand Up @@ -82,20 +82,20 @@ function validateDsn(dsn: DsnComponents): boolean | void {
const requiredComponents: ReadonlyArray<keyof DsnComponents> = ['protocol', 'publicKey', 'host', 'projectId'];
requiredComponents.forEach(component => {
if (!dsn[component]) {
throw new SentryError(`Invalid Dsn: ${component} missing`);
throw new SentryError(`Invalid Sentry Dsn: ${component} missing`);
}
});

if (!projectId.match(/^\d+$/)) {
throw new SentryError(`Invalid Dsn: Invalid projectId ${projectId}`);
throw new SentryError(`Invalid Sentry Dsn: Invalid projectId ${projectId}`);
}

if (!isValidProtocol(protocol)) {
throw new SentryError(`Invalid Dsn: Invalid protocol ${protocol}`);
throw new SentryError(`Invalid Sentry Dsn: Invalid protocol ${protocol}`);
}

if (port && isNaN(parseInt(port, 10))) {
throw new SentryError(`Invalid Dsn: Invalid port ${port}`);
throw new SentryError(`Invalid Sentry Dsn: Invalid port ${port}`);
}

return true;
Expand Down