test(browser): Add integration tests for captureMessage
#4351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
onurtemizkan
changed the title
captureMessagecaptureMessage
AbhiPrasad
reviewed
Dec 21, 2021
|
|
||
| expect(eventData.message).toBe('message_with_hint'); | ||
| expect(eventData.level).toBe('error'); | ||
| expect((eventData as Event & { hint: EventHint }).hint.captureContext).toMatchObject({ |
Member
There was a problem hiding this comment.
I don't think we need to assert on the hint here, we can just unit test that.
AbhiPrasad
reviewed
Dec 21, 2021
| Sentry.init({ | ||
| dsn: 'https://[email protected]/1337', | ||
| beforeSend: event => { | ||
| window.events.push(event); |
Collaborator
Author
There was a problem hiding this comment.
@AbhiPrasad, I have opened a PR for an alternative implementation for getting multiple events into tests without this hack. could you take a look? -> #4355
… into onur/public-api-tests-capture-message
onurtemizkan
force-pushed
the
onur/public-api-tests-capture-message
branch
from
2f4d184 to
11254fc
Compare
AbhiPrasad
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #4333