Skip to content

ref(browser): Extract trycatch private methods into functions #4305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2021
Merged

ref(browser): Extract trycatch private methods into functions #4305

merged 2 commits into from
Dec 15, 2021

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Dec 15, 2021

Improve bundle size by extracting these private methods into functions. Validated with integration tests + manual testing for addEventListener.

@AbhiPrasad AbhiPrasad added this to the Treeshaking / Bundle Size milestone Dec 15, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2021 •
edited
Loading

size-limit report

Path Base Size (21ea870) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 21.19 KB 21.17 KB -0.1% 🔽
@sentry/browser - CDN Bundle (minified) 67.98 KB 67.7 KB -0.41% 🔽
@sentry/browser - Webpack 22.92 KB 22.79 KB -0.54% 🔽
@sentry/browser - Webpack - gzip = false 78.82 KB 78.22 KB -0.76% 🔽
@sentry/react - Webpack 22.95 KB 22.83 KB -0.54% 🔽
@sentry/nextjs Client - Webpack 47.41 KB 47.33 KB -0.18% 🔽
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.4 KB 29.37 KB -0.12% 🔽

@mitsuhiko mitsuhiko merged commit fb87d34 into master Dec 15, 2021
@mitsuhiko mitsuhiko deleted the abhi-trycatch-private branch December 15, 2021 23:54
onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
@AbhiPrasad @onurtemizkan
ref(browser): Extract trycatch private methods into functions (#4305)
350459c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mitsuhiko mitsuhiko mitsuhiko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Tree shaking / Bundle Size

Development

Successfully merging this pull request may close these issues.

3 participants

@AbhiPrasad @mitsuhiko