Skip to content

chore(build): Fix missed es5 to cjs conversions in build commands #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2021
Merged

chore(build): Fix missed es5 to cjs conversions in build commands #4243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
"private": true,
"scripts": {
"build": "node ./scripts/verify-packages-versions.js && lerna run --stream --concurrency 1 --sort build",
"build:cjs": "lerna run --stream --concurrency 1 --sort build:cjs",
"build:dev": "lerna run --stream --concurrency 1 --sort build:dev",
"build:dev:filter": "lerna run --stream --concurrency 1 --sort build:dev --include-filtered-dependencies --include-filtered-dependents --scope",
"build:es5": "lerna run --stream --concurrency 1 --sort build:es5",
"build:es5": "yarn lerna run --stream --concurrency 1 --sort build:cjs # *** backwards compatibility - remove in v7 ***",
"build:esm": "lerna run --stream --concurrency 1 --sort build:esm",
"build:watch": "lerna run --parallel build:watch",
"build:dev:watch": "lerna run --parallel build:dev:watch",
Expand Down
2 changes: 1 addition & 1 deletion packages/nextjs/vercel/install-sentry-from-branch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ echo " "
echo "BUILDING SDK"
# We need to build es5 versions because `next.config.js` calls `require` on the SDK (to get `withSentryConfig`) and
# therefore it looks for `dist/index.js`
yarn build:es5
yarn build:cjs
# We need to build esm versions because that's what `next` actually uses when it builds the app
yarn build:esm

Expand Down