Skip to content

chore(build): Fix missed es5 to cjs conversions in build commands #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2021
Merged

chore(build): Fix missed es5 to cjs conversions in build commands #4243

merged 1 commit into from
Dec 7, 2021

Conversation

@lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Dec 7, 2021 •
edited
Loading

Follow up to #4178.

This fixes two spots which were missed when converting the build command from build:es5 to build:cjs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

size-limit report

Path Base Size (1d93ca9) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 22.45 KB 22.45 KB +0.02% 🔺
@sentry/browser - Webpack 23.29 KB 23.29 KB 0%
@sentry/react - Webpack 23.32 KB 23.32 KB 0%
@sentry/nextjs Client - Webpack 47.98 KB 47.98 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.9 KB 29.9 KB +0.01% 🔺

@lobsterkatie lobsterkatie merged commit f174166 into master Dec 7, 2021
@lobsterkatie lobsterkatie deleted the kmclb-tsconfig-es5-to-cjs-follow-up branch December 7, 2021 14:58
onurtemizkan pushed a commit that referenced this pull request Dec 19, 2021
@lobsterkatie @onurtemizkan
chore(build): Fix missed es5 to cjs conversions in build commands (…
e289050 
…#4243)

Follow up to #4178.

This fixes two spots which were missed when converting the build command from `build:es5` to `build:cjs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lobsterkatie @iker-barriocanal