From 4bbc8f7f4be2aac61dbd881d6cb9c67dce5a6951 Mon Sep 17 00:00:00 2001 From: Rodolfo Carvalho Date: Fri, 3 Dec 2021 12:12:57 +0100 Subject: [PATCH] ci: Re-enable part of @sentry/browser integration tests The integration tests still work, independent of running them on multiple browsers through BrowserStack. This change re-enables part of the old "BrowserStack" job, without the BrowserStack-dependant part. It is unclear why we disabled everything at once, seems like an oversight. --- .github/workflows/build.yml | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 09c61e3a380d..d9da64eafae7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -268,15 +268,12 @@ jobs: ${{ github.workspace }}/packages/**/*.tgz ${{ github.workspace }}/packages/serverless/dist-awslambda-layer/*.zip - job_browserstack_test: - name: BrowserStack + job_browser_integration_tests: + name: Browser Integration Tests needs: job_build runs-on: ubuntu-latest - timeout-minutes: 45 + timeout-minutes: 15 continue-on-error: true - # TODO: Fix BrowserStack tests - # if: startsWith(github.ref, 'refs/heads/release/') - if: false steps: - name: Check out current commit (${{ github.sha }}) uses: actions/checkout@v2 @@ -293,11 +290,7 @@ jobs: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ env.BUILD_CACHE_KEY }} - name: Run integration tests - env: - BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }} - BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }} run: | cd packages/browser - yarn test:integration:checkbrowsers yarn test:integration yarn test:package