From 9732ad8e6c3c99276b158ec3d07291e9c5ba5eb9 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Thu, 2 Dec 2021 13:30:14 -0500 Subject: [PATCH 1/4] fix(node): Make http integration spans have http span operation --- packages/node/src/integrations/http.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node/src/integrations/http.ts b/packages/node/src/integrations/http.ts index 9f6285d703c1..561f0fde0f47 100644 --- a/packages/node/src/integrations/http.ts +++ b/packages/node/src/integrations/http.ts @@ -114,7 +114,7 @@ function _createWrappedRequestMethodFactory( if (parentSpan) { span = parentSpan.startChild({ description: `${requestOptions.method || 'GET'} ${requestUrl}`, - op: 'request', + op: 'http', }); const sentryTraceHeader = span.toTraceparent(); From 2d564e662b576e25fd77c1b5e70473407b187063 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Fri, 3 Dec 2021 09:03:09 -0500 Subject: [PATCH 2/4] change to http.client --- packages/node/src/integrations/http.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node/src/integrations/http.ts b/packages/node/src/integrations/http.ts index 561f0fde0f47..6307f6008fc1 100644 --- a/packages/node/src/integrations/http.ts +++ b/packages/node/src/integrations/http.ts @@ -114,7 +114,7 @@ function _createWrappedRequestMethodFactory( if (parentSpan) { span = parentSpan.startChild({ description: `${requestOptions.method || 'GET'} ${requestUrl}`, - op: 'http', + op: 'http.client', }); const sentryTraceHeader = span.toTraceparent(); From 83d10e2e873172d17150ef33580d0867d00070a8 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Fri, 3 Dec 2021 09:17:00 -0500 Subject: [PATCH 3/4] fix test --- packages/node/test/integrations/http.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node/test/integrations/http.test.ts b/packages/node/test/integrations/http.test.ts index 824768481504..36c17ec7cd51 100644 --- a/packages/node/test/integrations/http.test.ts +++ b/packages/node/test/integrations/http.test.ts @@ -52,7 +52,7 @@ describe('tracing', () => { // our span is at index 1 because the transaction itself is at index 0 expect(spans[1].description).toEqual('GET http://dogs.are.great/'); - expect(spans[1].op).toEqual('request'); + expect(spans[1].op).toEqual('http.client'); }); it("doesn't create a span for outgoing sentry requests", () => { From 4cb59c8e8e75e6de40341c2caf6d5fe6b2a3812c Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Fri, 3 Dec 2021 09:31:44 -0500 Subject: [PATCH 4/4] fix nextjs test --- packages/nextjs/test/integration/test/server/tracingHttp.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nextjs/test/integration/test/server/tracingHttp.js b/packages/nextjs/test/integration/test/server/tracingHttp.js index 3494c5054582..02a61a78a047 100644 --- a/packages/nextjs/test/integration/test/server/tracingHttp.js +++ b/packages/nextjs/test/integration/test/server/tracingHttp.js @@ -25,7 +25,7 @@ module.exports = async ({ url: urlBase, argv }) => { spans: [ { description: 'GET http://example.com/', - op: 'request', + op: 'http.client', status: 'ok', tags: { 'http.status_code': '200' }, },