ref(nextjs): Use real functions in client init tests #4092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
AbhiPrasad
approved these changes
Oct 27, 2021
lobsterkatie
deleted the
kmclb-nextjs-use-real-functions-in-index-client-tests
branch
iker-barriocanal
approved these changes
Oct 27, 2021
Contributor
iker-barriocanal
left a comment
iker-barriocanal
left a comment
There was a problem hiding this comment.
nit: can set the pr type to "test"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the structure of the
index.client.tstests to stop mockingconfigureScopeand@sentry/react'sinitfunctions and instead spy on the real versions. This makes the structure of the client tests better match the structure of the server tests, and is also necessary for an upcoming PR in which the behavior of those functions is tested directly (meaning they have to actually do the thing they normally would).