Skip to content

fix(node): Prioritize globalAgent while figuring out protocol. #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 3, 2021
Merged

fix(node): Prioritize globalAgent while figuring out protocol. #4087

merged 3 commits into from
Nov 3, 2021

Conversation

@onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Oct 26, 2021

Fixes: #4080

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2021 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.47 KB (+0.01% 🔺)
@sentry/browser - Webpack 23.35 KB (0%)
@sentry/react - Webpack 23.38 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.92 KB (+0.01% 🔺)

@kamilogorek
Copy link
Contributor

kamilogorek commented Oct 26, 2021

Other than failing tests, the change itself looks good to me

@onurtemizkan
Copy link
Collaborator Author

onurtemizkan commented Oct 26, 2021

@kamilogorek, it's weird that this test gets errors from nocks interceptors (especially node 16 case). I can confirm the repro case in #4080 (comment) works as expected for node 16 as well as the other node versions above 8. So, I guess that might be an issue with nock itself. If you're comfortable merging this without a test case, I can remove it, or dig deeper about what caused that.

@kamilogorek kamilogorek enabled auto-merge (squash) November 3, 2021 15:42
@kamilogorek
Copy link
Contributor

kamilogorek commented Nov 3, 2021

@onurtemizkan fixed it (kinda :3)

@kamilogorek kamilogorek merged commit ac20799 into master Nov 3, 2021
@kamilogorek kamilogorek deleted the onur/node-http-proxy branch November 3, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kamilogorek kamilogorek kamilogorek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Http integration with proxy enabled throws ERR_INVALID_PROTOCOL error

3 participants

@onurtemizkan @kamilogorek