feat(integrations): Call toJSON of originalException to extract more data #4038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
requested review from
a team,
AbhiPrasad and
iker-barriocanal
and removed request for
a team
kamilogorek
commented
Oct 8, 2021
Contributor
size-limit report
|
Contributor
iker-barriocanal
left a comment
iker-barriocanal
left a comment
There was a problem hiding this comment.
Missing a test where toJSON overwrites a property.
Contributor
iker-barriocanal
left a comment
iker-barriocanal
left a comment
There was a problem hiding this comment.
I'd test that toJSON is able to rewrite native props, different from having priority over the directly assigned ones.
Contributor
Author
|
@iker-barriocanal added one remaining test |
kamilogorek
force-pushed
the
tojson-extra-error-data
branch
from
66f28a0 to
0cc9fdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4022